Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v0.1.3 semver-trick release for nb 1.0 #34

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Prepare v0.1.3 semver-trick release for nb 1.0 #34

merged 5 commits into from
Jul 10, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jul 3, 2020

The changelog for 1.0 does not contain the entry for 0.1.3, though. I could add it before the release in #33

@thejpster thejpster mentioned this pull request Jul 3, 2020
Closed
10 tasks
@eldruin
Copy link
Member Author

eldruin commented Jul 4, 2020 •
edited
Loading

I am not sure I have done this right. Trying to build with a patched nb 1.0 via:

[patch.crates-io]
nb = { git = "http://github.com/eldruin/nb", branch = "prepare-1.0.0" }

it builds fine but trying to run the tests I get this error:

cargo +nightly test
    Updating git repository `http://github.com/eldruin/nb`
    Updating crates.io index
   Compiling nb v1.0.0 (http://github.com/eldruin/nb?branch=prepare-1.0.0#88eb3a04)
   Compiling nb v0.1.3 (/Users/eldruin/projects/rust/nb)
    Finished test [unoptimized + debuginfo] target(s) in 4.86s
     Running target/debug/deps/nb-8fff419367ff7817

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests nb
error[E0465]: multiple rlib candidates for `nb` found
   --> /Users/eldruin/projects/rust/nb/src/lib.rs:360:1
    |
360 | extern crate nb;
    | ^^^^^^^^^^^^^^^^
    |
note: candidate #1: /Users/eldruin/projects/rust/nb/target/debug/deps/libnb-c6e48575d4689b81.rlib
   --> /Users/eldruin/projects/rust/nb/src/lib.rs:360:1
    |
360 | extern crate nb;
    | ^^^^^^^^^^^^^^^^
note: candidate #2: /Users/eldruin/projects/rust/nb/target/debug/deps/libnb-d4482eca8b1336d7.rlib
   --> /Users/eldruin/projects/rust/nb/src/lib.rs:360:1
    |
360 | extern crate nb;
    | ^^^^^^^^^^^^^^^^

error[E0463]: can't find crate for `nb`
   --> /Users/eldruin/projects/rust/nb/src/lib.rs:360:1
    |
360 | extern crate nb;
    | ^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0463`.
error: test failed, to rerun pass '--doc'

Any ideas?
Is this just because there is no published 1.0.0 version?

(Note: this is the reason for this PR being marked as draft)

@eldruin eldruin marked this pull request as draft July 4, 2020 07:02
@eldruin
Copy link
Member Author

eldruin commented Jul 7, 2020

Even with the published nb = "1" I am seeing the same error. What am I missing?

@eldruin
Copy link
Member Author

eldruin commented Jul 7, 2020

I have not seen it documented anywhere but this seems like a known issue: https://github.com/rust-num/num-traits/blob/c9727a60511de4983a3083e94a6e2ca1f44ea3cc/Cargo.toml#L15

@eldruin eldruin marked this pull request as ready for review July 7, 2020 20:56
@eldruin
Copy link
Member Author

eldruin commented Jul 10, 2020

Can I get a review here @rust-embedded/hal ?

therealprof
therealprof approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed that.

bors r+

bors bot added a commit that referenced this pull request Jul 10, 2020
@bors @eldruin
Merge #34
dbecf9b 
34: Prepare v0.1.3 semver-trick release for nb 1.0 r=therealprof a=eldruin

The changelog for 1.0 does not contain the entry for 0.1.3, though. I could add it before the release in #33 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@therealprof
Copy link
Contributor

I guess we'll have to merge manually, there's no branch protection setup for this branch. 😅

@therealprof therealprof merged commit 1209632 into rust-embedded:v0.1.x Jul 10, 2020
@eldruin eldruin deleted the semver-trick-1.0.0 branch July 10, 2020 07:00
@eldruin
Copy link
Member Author

eldruin commented Jul 10, 2020

Thanks! could you publish the new version as well?

@therealprof
Copy link
Contributor

Sure.

@therealprof
Copy link
Contributor

Done.

@eldruin
Copy link
Member Author

eldruin commented Jul 10, 2020

Awesome. Thank you!

@bors
Copy link
Contributor

bors bot commented Jul 10, 2020

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eldruin @therealprof